Some improvements for remote dependency lookups #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow, thanks for the PR, LGTM, will merge it :) |
|
cool :) yeah, why not. I'm still working with component on a daily basis, might as well add some improvements and fixes :) |
|
welcome on board :) |
timaschew
added a commit
that referenced
this pull request
Dec 6, 2014
Some improvements for remote dependency lookups
|
💃 |
|
do you want to add the camelCase fix? then we can publish a new version of the builder to npm |
|
working on it now. will send another pr |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to lookup a remote dependency's relative without extension.
require('repo/filename')See: https://github.com/tetsuo/builder2.js/blob/patch-js-relative-extension/test/fixtures/js-relative-extension-deps/index.js
Factored out lookup stuff to
builders/lookup.jsnot sure if that's the appropriate place for it, couldn't think of somewhere else.