Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ca31865

Browse filesBrowse files
committed
normalize URLs in CSS files
closes #132 #119 #96
1 parent 291be5e commit ca31865
Copy full SHA for ca31865

File tree

Expand file treeCollapse file tree

2 files changed

+8
-4
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+8
-4
lines changed

‎lib/builder.js

Copy file name to clipboardExpand all lines: lib/builder.js
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ var fs = require('fs')
1818
, utils = require('./utils')
1919
, dirname = path.dirname
2020
, basename = path.basename
21+
, resolveURL = require('url').resolve
2122
, strtojs = require('string-to-js');
2223

2324
/**
@@ -989,7 +990,10 @@ function rewriteUrls(builder, file, css) {
989990
if (isData(url)) return orig;
990991
if (isAbsolute(url)) return orig;
991992
var name = normalize(builder.basename);
992-
url = [builder.urlPrefix, name, dirname(file), url].filter(empty).join('/');
993+
// trailing `/` needed to distinguish the URL as a folder
994+
// for `url.resolve()`
995+
var folder = [builder.urlPrefix, name, dirname(file)].filter(empty).join('/') + '/';
996+
url = resolveURL(folder, url);
993997
return 'url("' + url + '")';
994998
}
995999

‎test/builder.js

Copy file name to clipboardExpand all lines: test/builder.js
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,9 +243,9 @@ describe('Builder', function(){
243243
builder.prefixUrls('build');
244244
builder.build(function(err, res){
245245
if (err) return done(err);
246-
res.css.should.include('url("build/assets/./images/logo.png")');
247-
res.css.should.include('url("build/assets/./images/maru.jpeg")');
248-
res.css.should.include('url("build/assets/css/../images/npm.png")');
246+
res.css.should.include('url("build/assets/images/logo.png")');
247+
res.css.should.include('url("build/assets/images/maru.jpeg")');
248+
res.css.should.include('url("build/assets/images/npm.png")');
249249
res.css.should.include('url(http://example.com/images/manny.png)');
250250
res.css.should.include('url(/public/images/foo.png)')
251251
res.css.should.include('url(data:image/png;base64,PNG DATA HERE)');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.