Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor(BaseConfig): update function name, upgrade mypy version #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2025
Merged

refactor(BaseConfig): update function name, upgrade mypy version #1444

merged 2 commits into from
May 23, 2025
+70 −76

Conversation

bearomorphism
Copy link
Contributor

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

bearomorphism
bearomorphism commented May 20, 2025
View reviewed changes
commitizen/config/base_config.py Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (refactors@225fd76). Learn more about missing BASE report.

Additional details and impacted files 
@@             Coverage Diff              @@
##             refactors    #1444   +/-   ##
============================================
  Coverage             ?   97.62%           
============================================
  Files                ?       57           
  Lines                ?     2654           
  Branches             ?        0           
============================================
  Hits                 ?     2591           
  Misses               ?       63           
  Partials             ?        0
Flag Coverage Δ
unittests 97.62% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism force-pushed the refactor-config branch 7 times, most recently from 45fe774 to 117e61c Compare May 20, 2025 15:51
@bearomorphism bearomorphism changed the title refactor(BaseConfig): remove path property refactor(BaseConfig): update function name May 20, 2025
@bearomorphism bearomorphism changed the title refactor(BaseConfig): update function name refactor(BaseConfig): update function name, upgrade mypy version May 20, 2025
Lee-W
Lee-W reviewed May 22, 2025
View reviewed changes
commitizen/config/base_config.py Outdated Show resolved Hide resolved
@Lee-W Lee-W changed the base branch from master to refactors May 23, 2025 03:22
@Lee-W Lee-W merged commit 50fd65f into commitizen-tools:refactors May 23, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile woile is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

Assignees
No one assigned
Labels
pr-status: wait-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bearomorphism @Lee-W
Morty Proxy This is a proxified and sanitized view of the page, visit original site.