Description
Description
Hello,
Thanks for creating and maintaining this great library 🙏
I found out that build: commits don't qualify as eligible for bumping anymore. I couldn't find any information if this is an expected behaviour, so I guess it might be a potential bug. It seems that it was working in 3.2.1 since it was the version that I was using before updating to the latest one.
Steps to reproduce
𝝺 cz c
? Select the type of change you are committing build: Changes that affect the build system or external dependencies (example scopes: pip, docker, npm)
? What is the scope of this change? (class or file name): (press [enter] to skip)
? Write a short and imperative summary of the code changes: (lower case and no period)
dockerfile parent image update
? Provide additional contextual information about the code changes: (press [enter] to skip)
? Is this a BREAKING CHANGE? Correlates with MAJOR in SemVer No
? Footer. Information about Breaking Changes and reference issues that this commit closes: (press [enter] to skip)
build: dockerfile parent image update
[feat/dockerfile 71292a7] build: dockerfile parent image update
1 file changed, 1 insertion(+), 1 deletion(-)
Commit successful!
𝝺 cz bump
[ci skip] bump: 0.2.0 → 0.2.0
tag to create: v0.2.0
[NO_COMMITS_TO_BUMP]
The commits found are not eligible to be bumped
Although, if I select the BREAKING CHANGE, it's bumped.
𝝺 cz c
? Select the type of change you are committing build: Changes that affect the build system or external dependencies (example scopes: pip, docker, npm)
? What is the scope of this change? (class or file name): (press [enter] to skip)
? Write a short and imperative summary of the code changes: (lower case and no period)
dockerfile
? Provide additional contextual information about the code changes: (press [enter] to skip)
? Is this a BREAKING CHANGE? Correlates with MAJOR in SemVer Yes
? Footer. Information about Breaking Changes and reference issues that this commit closes: (press [enter] to skip)
build: dockerfile
BREAKING CHANGE:
[feat/dockerfile 3439504] build: dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)
Commit successful!
𝝺 cz bump
[ci skip] bump: 0.2.0 → 1.0.0
tag to create: v1.0.0
increment detected: MAJOR
[feat/search-gate 2404a26] [ci skip] bump: 0.7.0 → 1.0.0
3 files changed, 4 insertions(+), 4 deletions(-)
Done!
Current behavior
As you can see, I can't bump the version after committing a build change. I also noticed that ci is not eligible either, so probably more of the commits type are influenced by this.
Documentation says that everything other than a BREAKING CHANGE and feat should be bumped as PATCH, here's the link.
It works for breaking changes, so it seems it takes precedence over the commit types.
Desired behavior
I would argue that commits related to the build process, e.g. docker image version, O flags for the compiler, pip dependency updates, poetry.lock update, etc. should be bumped as PATCH at least. These changes may not necessarily change the code behaviour but they certainly change the environment and the state of the codebase which may lead to unexpected results.
I don't want to replace such commits with feats or fixes since the code itself is not changed.
If this is an expected behaviour, it would be good to reflect that in the documentation.
Screenshots
No response
Environment
𝝺 cz version --report
Commitizen Version: 3.5.2
Python Version: 3.11.4 (main, Jun 20 2023, 17:23:00) [Clang 14.0.3 (clang-1403.0.22.14.1)]
Operating System: Darwin
EDIT:
- added a note about
cibeing influenced too