fix-379 Fixing issue with default value on enums for help text#937
Open
ChrisHallett wants to merge 1 commit intocommandlineparser:developcommandlineparser/commandline:developfrom
Open
fix-379 Fixing issue with default value on enums for help text#937ChrisHallett wants to merge 1 commit intocommandlineparser:developcommandlineparser/commandline:developfrom
ChrisHallett wants to merge 1 commit intocommandlineparser:developcommandlineparser/commandline:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#379
This fixes the issue where the default value for the enum was not being displayed however there are some other issues with this.
Now it will output the enum in help text even if the enum is not included in the command. I believe this would require quite a rework of the input system in order to properly account for this edge case enum issue so not sure if that is actually what is wanted here.