Fix #490: Display appropriate separator when writing default enumerable values#895
Open
gfs wants to merge 1 commit intocommandlineparser:mastercommandlineparser/commandline:masterfrom
gfs:gfs/AddSeparatorToEnumerablegfs/commandline:gfs/AddSeparatorToEnumerableCopy head branch name to clipboard
Open
Fix #490: Display appropriate separator when writing default enumerable values#895gfs wants to merge 1 commit intocommandlineparser:mastercommandlineparser/commandline:masterfrom gfs:gfs/AddSeparatorToEnumerablegfs/commandline:gfs/AddSeparatorToEnumerableCopy head branch name to clipboard
gfs wants to merge 1 commit intocommandlineparser:mastercommandlineparser/commandline:masterfrom
gfs:gfs/AddSeparatorToEnumerablegfs/commandline:gfs/AddSeparatorToEnumerableCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the default values for an IEnumerable option are always written with spaces separating them, even when the separator is set to something else. This change reads the configured separator from the option to include in the generated Default value for the HelpText.
Adds a new test case to confirm behavior when separator is configured. Previous behavior is maintained if separator is not configured.
Fix #490