Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Small cleanup#832

Open
AntonC9018 wants to merge 2 commits intocommandlineparser:mastercommandlineparser/commandline:masterfrom
AntonC9018:masterAntonC9018/commandline:masterCopy head branch name to clipboard
Open

Small cleanup#832
AntonC9018 wants to merge 2 commits intocommandlineparser:mastercommandlineparser/commandline:masterfrom
AntonC9018:masterAntonC9018/commandline:masterCopy head branch name to clipboard

Conversation

@AntonC9018
Copy link

@AntonC9018 AntonC9018 commented Jun 22, 2022

  • Typo fixes;
  • Make use of nameof for parameter names;
  • Make use of pattern matching with is instead of as and null check.

@ericnewton76 ericnewton76 changed the base branch from master to develop September 10, 2022 17:15
@ericnewton76 ericnewton76 changed the base branch from develop to master September 10, 2022 17:16
@ericnewton76
Copy link
Member

ericnewton76 commented Sep 10, 2022

Can you update/rebase your branch from current master?

@ericnewton76 ericnewton76 self-requested a review September 10, 2022 17:19
@AntonC9018
Copy link
Author

AntonC9018 commented Sep 10, 2022

not right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericnewton76 ericnewton76 Awaiting requested review from ericnewton76

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

awaiting response

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AntonC9018 @ericnewton76
Morty Proxy This is a proxified and sanitized view of the page, visit original site.