Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Remove System.Linq.Expressions dependency.#764

Merged
ericnewton76 merged 1 commit intocommandlineparser:developcommandlineparser/commandline:developfrom
NN---:remove_expressionNN---/commandline:remove_expressionCopy head branch name to clipboard
May 12, 2022
Merged

Remove System.Linq.Expressions dependency.#764
ericnewton76 merged 1 commit intocommandlineparser:developcommandlineparser/commandline:developfrom
NN---:remove_expressionNN---/commandline:remove_expressionCopy head branch name to clipboard

Conversation

@NN---
Copy link
Contributor

@NN--- NN--- commented Jun 26, 2021

The code is much simpler and it allows porting library to older framework.
theraot/Theraot#157.

@NN--- NN--- force-pushed the remove_expression branch from b9e6a18 to 31895f1 Compare June 27, 2021 15:37
@NN---
Copy link
Contributor Author

NN--- commented Oct 27, 2021

@moh-hassan Any update ?

Copy link
Member

@ericnewton76 ericnewton76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a SystemLinqExpressions nuget package that could be removed too?

nvm I see whats going on

Copy link
Member

@ericnewton76 ericnewton76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change, but I cant readily see the impact the change will make. I'm a little worried about merging it but I think it'll work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.