Required value no longer treated as option#763
Open
carstencodes wants to merge 3 commits intocommandlineparser:developcommandlineparser/commandline:developfrom
carstencodes:fixes/RequiredValueTreatedAsOptioncarstencodes/commandline:fixes/RequiredValueTreatedAsOptionCopy head branch name to clipboard
Open
Required value no longer treated as option#763carstencodes wants to merge 3 commits intocommandlineparser:developcommandlineparser/commandline:developfrom carstencodes:fixes/RequiredValueTreatedAsOptioncarstencodes/commandline:fixes/RequiredValueTreatedAsOptionCopy head branch name to clipboard
carstencodes wants to merge 3 commits intocommandlineparser:developcommandlineparser/commandline:developfrom
carstencodes:fixes/RequiredValueTreatedAsOptioncarstencodes/commandline:fixes/RequiredValueTreatedAsOptionCopy head branch name to clipboard
Conversation
added 3 commits
June 16, 2021 20:21
A required value, i.e. a positional argument, can be missing. The error message should reflect this issue.
The tests have been adjusted. The command line positional arguments will raise a different error. This is semantically a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing required values will be now longer treated as options.
Hence the error message will be clarified to the positional arguments.
This compares to option 3 from #755 .