Unparsing FileInfo and DirectoryInfo should add quotes to the path

FormatWithQuotesIfString currently honors DateTime, DateTimeOffset and string, but I'm using FileInfo and DirectoryInfo as options as well.

These types should also be surrounded by quotation marks when unparsed.

.NET Fiddle example

Affected code:

commandline/src/CommandLine/UnParserExtensions.cs

Lines 205 to 215 in 24e2be2

    
           private static object FormatWithQuotesIfString(object value) 
        
           { 
        
               if (value is DateTime || value is DateTimeOffset) return $"\"{value}\""; 
        
               Func<string, string> doubQt = v 
        
                   => v.Contains("\"") ? v.Replace("\"", "\\\"") : v; 
        
               return (value as string) 
        
                   .ToMaybe() 
        
                   .MapValueOrDefault(v => v.Contains(' ') || v.Contains("\"") 
        
                       ? "\"".JoinTo(doubQt(v), "\"") : v, value); 
        
           }

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unparsing FileInfo and DirectoryInfo should add quotes to the path #626

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	private static object FormatWithQuotesIfString(object value)
	{
	if (value is DateTime \|\| value is DateTimeOffset) return $"\"{value}\"";
	Func<string, string> doubQt = v
	=> v.Contains("\"") ? v.Replace("\"", "\\\"") : v;

	return (value as string)
	.ToMaybe()
	.MapValueOrDefault(v => v.Contains(' ') \|\| v.Contains("\"")
	? "\"".JoinTo(doubQt(v), "\"") : v, value);
	}

Search code, repositories, users, issues, pull requests...

Unparsing FileInfo and DirectoryInfo should add quotes to the path #626

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions