HKG: Add FW for 2024 Kia Forte #2805
Conversation
Add Forte 24
Add Forte 24. Modules fingerprint
ADD KIA_FORTE
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
|
Can you provide a dongle ID? |
Kia Forte 2024 is same as 21-23, Same Harness and Can Addresses,
Rearrange order
|
Dongle ID: 850678021a7879cc Route ID using Kia Forte 2023 car paramters on sunnypilot The latest commits are modifications from the previous ones, just the latest ones needed |
| CAR.HYUNDAI_SANTA_FE_2022, CAR.KIA_K5_2021, CAR.HYUNDAI_IONIQ_HEV_2022, CAR.HYUNDAI_SANTA_FE_HEV_2022, | ||
| CAR.HYUNDAI_SANTA_FE_PHEV_2022, CAR.KIA_STINGER_2022, CAR.KIA_K5_HEV_2020, CAR.KIA_CEED, | ||
| CAR.HYUNDAI_AZERA_6TH_GEN, CAR.HYUNDAI_AZERA_HEV_6TH_GEN, CAR.HYUNDAI_CUSTIN_1ST_GEN, CAR.HYUNDAI_KONA_2022): | ||
| CAR.HYUNDAI_AZERA_6TH_GEN, CAR.HYUNDAI_AZERA_HEV_6TH_GEN, CAR.HYUNDAI_CUSTIN_1ST_GEN, CAR.HYUNDAI_KONA_2022, CAR.KIA_FORTE): |
There was a problem hiding this comment.
Was it necessary to add this in order for your car to be usable? This is a substantial change for all other model-years of Kia Forte. Even if it's right for your car, we'd have to see if it breaks older Forte.
@sunnyhaibin this is my least favorite line of code in all of opendbc. Is there no way to auto-detect if we have a more modern instrument cluster?
There was a problem hiding this comment.
I tried a while ago but couldn't find any pattern in this message alone. That's not to say it's not possible though
Validation