fix(mempool): return correct number of transactions in ReapMaxTxs #5550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReapMaxTxs was returning max+1 transactions instead of max due to wrong loop condition. The check
len(txs) <= maxallowed one extra iteration after reaching the limit. Changed tolen(txs) < maxto stop at exactly max transactions.Note
Ensures the mempool returns the correct number of transactions when reaping by count.
ReapMaxTxsloop condition inmempool/clist_mempool.gofromlen(txs) <= maxtolen(txs) < maxto stop at exactlymaxtxsWritten by Cursor Bugbot for commit 2a79c77. This will update automatically on new commits. Configure here.