docs: align ABCI app requirements with current consensus params and keys #5516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ABCI application requirements to reflect current consensus parameters and key support. It replaces the obsolete FeatureParams/SynchronyParams references with ABCIParams.VoteExtensionsEnableHeight, renames the vote extensions section and fixes anchors, removes the unsupported secp256k1eth key type, and clarifies that PBTS is not governed by on-chain consensus parameters.
The BlockParams.MaxBytes “-1” semantics were intentionally kept, as they are implemented and documented elsewhere: -1 maps to a 100MB cap and causes CometBFT to provide all mempool txs to PrepareProposal. The proto comment indicating >0 is outdated relative to the implementation.
Note
Aligns ABCI app requirements with current consensus params: replace FeatureParams with
ABCIParams.VoteExtensionsEnableHeight, remove Synchrony params andsecp256k1ethkey type, fix anchors, and clarify PBTS is not a consensus parameter.spec/abci/abci++_app_requirements.md:FeatureParams.VoteExtensionsEnableHeightwithABCIParams.VoteExtensionsEnableHeightand update anchors/links.FeatureParams.PbtsEnableHeightandSynchronyParams.{Precision,MessageDelay}sections and references.ConsensusParams.secp256k1ethfromValidatorUpdatesupported types.Written by Cursor Bugbot for commit 846d7ac. This will update automatically on new commits. Configure here.