Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

milan-cb
Copy link
Contributor

@milan-cb milan-cb commented Feb 9, 2025

What changed? Why?

This change will add transaction receipts to contract invocations. After invoking a contract method, this new change will fetch the transaction receipt of the completed transaction and append the receipt contents, within the "content" field of the Transaction model for the Contract Invocation.

Qualified Impact

If there is any issue with this change, the best measure would be to rollback and then fix the error accordingly. This change will affect the content field which is a part of the Transaction model for the Contract Invocation, but there shouldn't be any issues with the structure of model, since there is no strict validation, and the schema on the backend directly matches the Transaction objects' fields.

@cb-heimdall
Copy link

cb-heimdall commented Feb 9, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@milan-cb milan-cb changed the base branch from master to v0.18.0 February 11, 2025 17:36
@milan-cb milan-cb changed the title feat: added support for transaction receipt on contract invocation (PSDK-55) feat: added support for transaction receipt on contract invocation (PSDK-44) Feb 12, 2025
@milan-cb milan-cb merged commit 769fd14 into v0.18.0 Feb 13, 2025
6 checks passed
@milan-cb milan-cb deleted the milan/PSDK-44 branch February 13, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.