Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 36daffc

Browse filesBrowse files
author
Ben Newman
committed
Cope with asynchronous ChildProcess.prototype.send in Node v4.
nodejs/node#2620 Part of meteor#6921.
1 parent 6a4241c commit 36daffc
Copy full SHA for 36daffc

File tree

Expand file treeCollapse file tree

1 file changed

+8
-2
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-2
lines changed

‎tools/runners/run-app.js

Copy file name to clipboardExpand all lines: tools/runners/run-app.js
+8-2Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -845,8 +845,14 @@ _.extend(AppRunner.prototype, {
845845
// Notify the server that new client assets have been added to the
846846
// build.
847847
self._refreshing = true;
848-
appProcess.proc.send({ refresh: 'client' });
849-
self._refreshing = false;
848+
// ChildProcess.prototype.send used to be synchronous, but is now
849+
// asynchronous: https://github.com/nodejs/node/pull/2620
850+
appProcess.proc.send({
851+
refresh: 'client'
852+
}, err => {
853+
self._refreshing = false;
854+
if (err) throw err;
855+
});
850856

851857
// Establish a watcher on the new files.
852858
setupClientWatcher();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.