Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[UI][RFC] SelectiveView #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from

Conversation

senwang86
Copy link
Collaborator

@senwang86 senwang86 commented Aug 26, 2023

Summary

A prototype of SelectiveView via multi-select items in ToC

  • The Canvas only displays selected pods.
  • The Edit mode is not affected.

However

  • The current implementation renders a deep copy of the selected pods from nodesMap in updateView(), thus ALL operations that engage with nodesMap need to be properly synced, e.g., moving a pod, creating a new pod, changing the size of a pod, etc. I am not exactly sure if it's the best approach and ask for some comments here.

Test

selective_view

@senwang86 senwang86 requested a review from lihebi August 26, 2023 02:14
@lihebi
Copy link
Collaborator

lihebi commented Aug 26, 2023

  • The current implementation renders a deep copy of the selected pods from nodesMap in updateView()

I didn't see "a deep copy". I think you are doing the right thing here, to compute a subset of nodes and set({nodes}).

However, I don't quite understand the gif/code:

  1. Your gif doesn't show a "partial view" of the canvas. All pods seem to be shown.
  2. The sidebar ToC should be "togglable" into three states (selected, hidden, blocked), something like this:

image

@senwang86
Copy link
Collaborator Author

  1. Your gif doesn't show a "partial view" of the canvas. All pods seem to be shown.

It's due to the native multi-selection of tree-view, instead of checkbox-based selection, the selective view happens when there're more than 1 items selected in ToC.

@lihebi
Copy link
Collaborator

lihebi commented Aug 26, 2023

the selective view happens when there're more than 1 items selected in ToC.

Oh, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.