Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit af1c43b

Browse filesBrowse files
committed
PR feedback: noOpacity; no need to add toSVG; no empty line after function line if it's the only empty line in the function body
1 parent 4c3521a commit af1c43b
Copy full SHA for af1c43b

File tree

3 files changed

+1
-6
lines changed
Filter options

3 files changed

+1
-6
lines changed

‎src/traces/sankey/base_plot.js

Copy file name to clipboardExpand all lines: src/traces/sankey/base_plot.js
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,3 @@ exports.clean = function(newFullData, newFullLayout, oldFullData, oldFullLayout)
2828
oldFullLayout._paperdiv.selectAll('.sankey').remove();
2929
}
3030
};
31-
32-
exports.toSVG = function() {};

‎src/traces/sankey/index.js

Copy file name to clipboardExpand all lines: src/traces/sankey/index.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Plot.plot = require('./plot');
1818
Plot.moduleType = 'trace';
1919
Plot.name = 'sankey';
2020
Plot.basePlotModule = require('./base_plot');
21-
Plot.categories = [];
21+
Plot.categories = ['noOpacity'];
2222
Plot.meta = {
2323
description: [
2424
'Sankey plots for network flow data analysis.',

‎src/traces/sankey/plot.js

Copy file name to clipboardExpand all lines: src/traces/sankey/plot.js
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ function relatedNodes(l) {
4747
}
4848

4949
function nodeHoveredStyle(sankeyNode, d, sankey) {
50-
5150
if(d && sankey) {
5251
ownTrace(sankey, d)
5352
.selectAll('.sankeyLink')
@@ -57,7 +56,6 @@ function nodeHoveredStyle(sankeyNode, d, sankey) {
5756
}
5857

5958
function nodeNonHoveredStyle(sankeyNode, d, sankey) {
60-
6159
if(d && sankey) {
6260
ownTrace(sankey, d)
6361
.selectAll('.sankeyLink')
@@ -175,7 +173,6 @@ module.exports = function plot(gd, calcData) {
175173
var nodeHoverFollow = function(element, d) {
176174

177175
var nodeRect = d3.select(element).select('.nodeRect');
178-
179176
var boundingBox = nodeRect.node().getBoundingClientRect();
180177
var hoverCenterX0 = boundingBox.left - 2;
181178
var hoverCenterX1 = boundingBox.right + 2;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.