Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 84bcd28

Browse filesBrowse files
olamyolamy
authored
minor cleanup (#198)
* minor cleanup Signed-off-by: Olivier Lamy <olamy@apache.org>
1 parent e5316f6 commit 84bcd28
Copy full SHA for 84bcd28

File tree

Expand file treeCollapse file tree

9 files changed

+21
-24
lines changed
Filter options
Expand file treeCollapse file tree

9 files changed

+21
-24
lines changed

‎plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/AbstractCompiler.java

Copy file name to clipboardExpand all lines: plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/AbstractCompiler.java
+7-7Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ public abstract class AbstractCompiler
4646

4747
protected static final String PS = System.getProperty( "path.separator" );
4848

49-
private CompilerOutputStyle compilerOutputStyle;
49+
private final CompilerOutputStyle compilerOutputStyle;
5050

51-
private String inputFileEnding;
51+
private final String inputFileEnding;
5252

53-
private String outputFileEnding;
53+
private final String outputFileEnding;
5454

55-
private String outputFile;
55+
private final String outputFile;
5656

5757
// ----------------------------------------------------------------------
5858
//
@@ -152,7 +152,7 @@ protected static Set<String> getSourceFilesForSourceRoot( CompilerConfiguration
152152

153153
if ( includes != null && !includes.isEmpty() )
154154
{
155-
String[] inclStrs = includes.toArray( new String[includes.size()] );
155+
String[] inclStrs = includes.toArray( new String[0] );
156156
scanner.setIncludes( inclStrs );
157157
}
158158
else
@@ -164,7 +164,7 @@ protected static Set<String> getSourceFilesForSourceRoot( CompilerConfiguration
164164

165165
if ( excludes != null && !excludes.isEmpty() )
166166
{
167-
String[] exclStrs = excludes.toArray( new String[excludes.size()] );
167+
String[] exclStrs = excludes.toArray( new String[0] );
168168
scanner.setExcludes( exclStrs );
169169
}
170170

@@ -213,7 +213,7 @@ protected static String[] getSourceFiles( CompilerConfiguration config )
213213
}
214214
else
215215
{
216-
result = sources.toArray( new String[sources.size()] );
216+
result = sources.toArray( new String[0] );
217217
}
218218

219219
return result;

‎plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/CompilerMessage.java

Copy file name to clipboardExpand all lines: plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/CompilerMessage.java
+1-4Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -339,11 +339,8 @@ public enum Kind
339339
*/
340340
WARNING( "warning" );
341341

342-
private String type;
343-
344-
private Kind( final String type )
342+
Kind( String type )
345343
{
346-
this.type = type;
347344
}
348345
}
349346
}

‎plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/CompilerOutputStyle.java

Copy file name to clipboardExpand all lines: plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/CompilerOutputStyle.java
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public String toString()
5757

5858
public boolean equals( Object other )
5959
{
60-
if ( other == null || !( other instanceof CompilerOutputStyle ) )
60+
if ( !( other instanceof CompilerOutputStyle ) )
6161
{
6262
return false;
6363
}

‎plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/util/StreamPumper.java

Copy file name to clipboardExpand all lines: plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/util/StreamPumper.java
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@ public class StreamPumper
3636
{
3737
private static final int BUFFER_SIZE = 512;
3838

39-
private BufferedInputStream stream;
39+
private final BufferedInputStream stream;
4040

4141
private boolean endOfStream = false;
4242

4343
private int SLEEP_TIME = 5;
4444

45-
private OutputStream out;
45+
private final OutputStream out;
4646

4747
public StreamPumper( BufferedInputStream is, OutputStream out )
4848
{

‎plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/util/scan/AbstractSourceInclusionScanner.java

Copy file name to clipboardExpand all lines: plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/util/scan/AbstractSourceInclusionScanner.java
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ protected String[] scanForSources( File sourceDir, Set<String> sourceIncludes, S
5656
}
5757
else
5858
{
59-
includes = sourceIncludes.toArray( new String[sourceIncludes.size()] );
59+
includes = sourceIncludes.toArray( new String[0] );
6060
}
6161

6262
ds.setIncludes( includes );
@@ -68,7 +68,7 @@ protected String[] scanForSources( File sourceDir, Set<String> sourceIncludes, S
6868
}
6969
else
7070
{
71-
excludes = sourceExcludes.toArray( new String[sourceExcludes.size()] );
71+
excludes = sourceExcludes.toArray( new String[0] );
7272
}
7373

7474
ds.setExcludes( excludes );

‎plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/util/scan/SimpleSourceInclusionScanner.java

Copy file name to clipboardExpand all lines: plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/util/scan/SimpleSourceInclusionScanner.java
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@
3838
public class SimpleSourceInclusionScanner
3939
extends AbstractSourceInclusionScanner
4040
{
41-
private Set<String> sourceIncludes;
41+
private final Set<String> sourceIncludes;
4242

43-
private Set<String> sourceExcludes;
43+
private final Set<String> sourceExcludes;
4444

4545
public SimpleSourceInclusionScanner( Set<String> sourceIncludes, Set<String> sourceExcludes )
4646
{

‎plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/util/scan/StaleSourceScanner.java

Copy file name to clipboardExpand all lines: plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/util/scan/StaleSourceScanner.java
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ public class StaleSourceScanner
4242

4343
public StaleSourceScanner()
4444
{
45-
this( 0, Collections.singleton( "**/*" ), Collections.<String>emptySet() );
45+
this( 0, Collections.singleton( "**/*" ), Collections.emptySet() );
4646
}
4747

4848
public StaleSourceScanner( long lastUpdatedWithinMsecs )
4949
{
50-
this( lastUpdatedWithinMsecs, Collections.singleton( "**/*" ), Collections.<String>emptySet() );
50+
this( lastUpdatedWithinMsecs, Collections.singleton( "**/*" ), Collections.emptySet() );
5151
}
5252

5353
public StaleSourceScanner( long lastUpdatedWithinMsecs, Set<String> sourceIncludes, Set<String> sourceExcludes )

‎plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/util/scan/mapping/SingleTargetSourceMapping.java

Copy file name to clipboardExpand all lines: plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/util/scan/mapping/SingleTargetSourceMapping.java
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@
3838
public class SingleTargetSourceMapping
3939
implements SourceMapping
4040
{
41-
private String sourceSuffix;
41+
private final String sourceSuffix;
4242

43-
private String outputFile;
43+
private final String outputFile;
4444

4545
public SingleTargetSourceMapping( String sourceSuffix, String outputFile )
4646
{

‎plexus-compilers/plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavacCompiler.java

Copy file name to clipboardExpand all lines: plexus-compilers/plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavacCompiler.java
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public class JavacCompiler
105105

106106
private static volatile Class<?> JAVAC_CLASS;
107107

108-
private List<Class<?>> javaccClasses = new CopyOnWriteArrayList<>();
108+
private final List<Class<?>> javaccClasses = new CopyOnWriteArrayList<>();
109109

110110
@Requirement
111111
private InProcessCompiler inProcessCompiler;
@@ -432,7 +432,7 @@ else if ( !suppressSource( config ) )
432432
args.add( value );
433433
}
434434

435-
return args.toArray( new String[args.size()] );
435+
return args.toArray( new String[0] );
436436
}
437437

438438
/**

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.