Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 21, 2025. It is now read-only.
This repository was archived by the owner on May 21, 2025. It is now read-only.

hg identify call fails because it uses a |, but try_to_run() is missing shell=True #284

Copy link
Copy link
Closed
@antonv6

Description

@antonv6
Issue body actions

Noticed by browsing somebody else's CI output:

 hg identify: option -d not recognized

But, as you can see in this file: https://github.com/codecov/codecov-python/blob/master/codecov/__init__.py#L865 the command's intent is to provide -d not to hg id, but to tr. It doesn't work because by default shell argument of try_to_run() is False.

The fix could be to just provide shell=True to that function, but I suggest to replace the whole call with try_to_run(['hg', 'log', '-r', '.', '-T', '{node}']).

Thank you for supporting Mercurial. If you have any questions, feel free to ping me.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.