This repository was archived by the owner on May 21, 2025. It is now read-only.
This repository was archived by the owner on May 21, 2025. It is now read-only.
hg identify call fails because it uses a |
, but try_to_run() is missing shell=True #284
Copy link
Copy link
Closed
Description
Noticed by browsing somebody else's CI output:
hg identify: option -d not recognized
But, as you can see in this file: https://github.com/codecov/codecov-python/blob/master/codecov/__init__.py#L865 the command's intent is to provide -d
not to hg id
, but to tr
. It doesn't work because by default shell
argument of try_to_run()
is False.
The fix could be to just provide shell=True to that function, but I suggest to replace the whole call with try_to_run(['hg', 'log', '-r', '.', '-T', '{node}'])
.
Thank you for supporting Mercurial. If you have any questions, feel free to ping me.
Metadata
Metadata
Assignees
Labels
No labels