Disable all assaults/watcher in integration-tests of chaos-monkey-demo-app #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ea2afa to
d208f12
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
============================================
- Coverage 82.31% 82.11% -0.21%
- Complexity 388 389 +1
============================================
Files 84 86 +2
Lines 950 928 -22
Branches 68 61 -7
============================================
- Hits 782 762 -20
- Misses 142 143 +1
+ Partials 26 23 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Disabled all watcher/aussaults in integrationstests of chaos-monkey-demo app.
Why:
When writing new integration tests its quiet missleading when unexpected assaults happens. By disabling all assaults and watchers, this wont happen.
How:
Renamed application-test.properties to application.properties and disabled all watchers/aussaults by setting them to false.
Checklist: