pin py42 for cli versions < 1.0 to < 1.8.0#144
Merged
pin py42 for cli versions < 1.0 to < 1.8.0#144
Conversation
antazoey
reviewed
Aug 25, 2020
| @@ -1 +1 @@ | ||
| __version__ = "0.7.3" | ||
| __version__ = "0.7.4" |
Contributor
There was a problem hiding this comment.
Should we add an empty changelog?
Contributor
Author
There was a problem hiding this comment.
We'll add that entry to master separately since don't intend to merge this there.
antazoey
approved these changes
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
py42 version 1.8 will introduce new exception types that will be thrown in py42 rather than in the cli. Because the existing releases do not catch these exceptions, some existing error situations would be logged to error files instead of having their messages output to the console. Pinning the py42 version until we create a release that properly catches the new py42 errors corrects this.