Added .npmignore so /dist folder would be included in the NPM package #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddiedierker
approved these changes
Jun 3, 2021
I don't know why. Molly's published from here recently, so I'm planning to check in with her when she gets back from vacation to see if she's hit similar issues. I'm fine sitting on this PR until after then to see if there's a better way to handle this. |
|
This definitely shouldn't be necessary. https://github.com/code-dot-org/redactable-markdown is an example of a repository that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our /dist folder contains the executable code in the NPM package. However, since it is ignored in our gitignore, it gets excluded from the NPM package. Adding an empty .npmignore solves this issue by setting itself up as higher precidence than the gitignore for the NPM publish command.
Note: This means other folders such as "coverage" or anything excluded by the .gitignore will also be included in the npm package
Details: https://docs.npmjs.com/cli/v7/using-npm/developers
https://codedotorg.slack.com/archives/C0T0PNR0D/p1622673362009700