code-cracker · chp2y · Oct 4, 2018 · Nov 22, 2018 · Nov 22, 2018
diff --git a/runTestsCS.ps1 b/runTestsCS.ps1
@@ -2,7 +2,7 @@ param([String]$testClass)
 $testDllDirPath = "$PSScriptRoot\test\CSharp\CodeCracker.Test\bin\Debug\"
 $testDllFileName = "CodeCracker.Test.CSharp.dll"
 $testDllFullFileName = "$testDllDirPath$testDllFileName"
-$xunitConsole = "$PSScriptRoot\packages\xunit.runner.console.2.2.0\tools\xunit.console.x86.exe"
+$xunitConsole = "$PSScriptRoot\packages\xunit.runner.console.2.3.1\tools\net452\xunit.console.exe"

 if (!(gcm nodemon -ErrorAction Ignore)) {
    Write-Host -ForegroundColor DarkRed 'Nodemon not found, install it with npm: `npm i -g nodemon`'

diff --git a/runTestsVB.ps1 b/runTestsVB.ps1
@@ -2,7 +2,7 @@ param([String]$testClass)
 $testDllDirPath = "$PSScriptRoot\test\VisualBasic\CodeCracker.Test\bin\Debug\"
 $testDllFileName = "CodeCracker.Test.VisualBasic.dll"
 $testDllFullFileName = "$testDllDirPath$testDllFileName"
-$xunitConsole = "$PSScriptRoot\packages\xunit.runner.console.2.2.0\tools\xunit.console.x86.exe"
+$xunitConsole = "$PSScriptRoot\packages\xunit.runner.console.2.3.1\tools\net452\xunit.console.exe"

 if (!(gcm nodemon -ErrorAction Ignore)) {
    Write-Host -ForegroundColor DarkRed 'Nodemon not found, install it with npm: `npm i -g nodemon`'

diff --git a/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs b/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs
@@ -3,7 +3,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using System;
 using System.Collections.Immutable;
 using System.Linq;

@@ -57,6 +56,12 @@ private static void AnalyzeProperty(SyntaxNodeAnalysisContext context, bool canH
            if (returnIdentifier == null) return;
            var semanticModel = context.SemanticModel;
            var fieldSymbol = semanticModel.GetSymbolInfo(returnIdentifier).Symbol;
+            var outerClass = context.Node.Ancestors().OfType<ClassDeclarationSyntax>().LastOrDefault();
+            if (outerClass != null && IsBackingFieldRefOrOutParam(fieldSymbol, outerClass, semanticModel))
+            {
+                return;
+            }
+
            if (fieldSymbol == null) return;
            var assignmentLeftIdentifier = (setterAssignmentExpression.Left is MemberAccessExpressionSyntax &&
                ((MemberAccessExpressionSyntax)setterAssignmentExpression.Left).Expression is ThisExpressionSyntax ? ((MemberAccessExpressionSyntax)setterAssignmentExpression.Left).Name : setterAssignmentExpression.Left) as IdentifierNameSyntax;
@@ -79,5 +84,25 @@ private static void AnalyzeProperty(SyntaxNodeAnalysisContext context, bool canH
            var diag = Diagnostic.Create(Rule, property.GetLocation(), property.Identifier.Text);
            context.ReportDiagnostic(diag);
        }
+
+        private static bool IsBackingFieldRefOrOutParam(ISymbol fieldSymbol, ClassDeclarationSyntax outerClass, SemanticModel semanticModel)
+        {
+            foreach (var descendant in outerClass.DescendantNodes().OfType<IdentifierNameSyntax>())
+            {
+                var descendentSymbol = semanticModel.GetSymbolInfo(descendant).Symbol;
+                if (descendentSymbol != null && descendentSymbol.Equals(fieldSymbol))
+                {
+                    // The field is being referenced
+                    // Next we check whether it is referenced as an argument and passed by ref/out
+                    var argument = descendant.AncestorsAndSelf().OfType<ArgumentSyntax>().FirstOrDefault();
+                    if (argument != null && !argument.RefOrOutKeyword.IsKind(SyntaxKind.None))
+                    {
+                        return true;
+                    }
+                }
+            }
+
+            return false;
+        }
    }
-}
+}
diff --git a/test/CSharp/CodeCracker.Test/Style/SwitchToAutoPropTests.cs b/test/CSharp/CodeCracker.Test/Style/SwitchToAutoPropTests.cs
@@ -267,6 +267,69 @@ public int Id
            await VerifyCSharpHasNoDiagnosticsAsync(source, LanguageVersion.CSharp5);
        }

+        [Fact]
+        public async Task IgnoresWhenPropertyIsUsedWithOut()
+        {
+            const string source = @"
+namespace ConsoleApplication1
+{
+    class CC0017
+    {
+        public int MyThing
+        {
+            get { return _myThing; }
+            set { _myThing = value; }
+        }
+        private int _myThing;
+
+        public static void SetOut(ref int field)
+        {
+            field = 42;
+        }
+
+        public CC0017()
+        {
+            SetOut(ref _myThing);
+        }
+    }
+}";
+            await VerifyCSharpHasNoDiagnosticsAsync(source);
+        }
+
+        [Fact]
+        public async Task IgnoresWhenPropertyIsUsedWithRef()
+        {
+            const string source = @"
+namespace ConsoleApplication1
+{
+    class CC0017
+    {
+        public int MyThing
+        {
+            get { return _myThing; }
+            set { _myThing = value; }
+        }
+        private int _myThing;
+
+        public void IncrementRef()
+        {
+            Interlocked.Increment(ref _myThing);
+        }
+
+        public static void SetOut(out int field)
+        {
+            field = 42;
+        }
+
+        public CC0017()
+        {
+            SetOut(out _myThing);
+        }
+    }
+}";
+            await VerifyCSharpHasNoDiagnosticsAsync(source);
+        }
+
        [Fact]
        public async Task SimplePropertyCreatesDiagnostic()
        {