Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Move status logic from StripeAccountView into a separate module #599

Copy link
Copy link
@begedin

Description

@begedin
Issue body actions

Problem

The StripeConnectAccountView logic here can be moved into a separate module, with only the basic placeholder fields remaining in the view, to simplify things:

def recipient_status(record, _conn), do: AccountVerificationStatus.recipient(record)
def bank_account_status(record, _conn), do: AccountVerificationStatus.bank_account(record)
def personal_id_number_status(record, _conn), do: AccountVerificationStatus.personal_id_number(record)
def verification_document_status(record, _conn), do: AccountVerificationStatus.verification_document(record)

Subtasks

  • Move logic to separate module
  • Add "delegation" methods to view
  • Add tests for module, simplify tests for view

Discussion

Where do we put the module? I'm thinking something like lib/code_corps/presenters/account_verification_status.ex. Could use your thoughts, @joshsmith.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.