Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add fallback for GitHub avatars when async processing #1017

Copy link
Copy link
@joshsmith

Description

@joshsmith
Issue body actions

Problem

For the fallback:

  • Rewrites the cloudinary_image/5 fn signature to accept the User's github_avatar_url in addition to the cloudinary_public_id
  • In CloudinaryUrl.for/5, pattern match on the presence of a github_avatar_url in order to instead use the GitHub avatar URL as a fallback (with the right sizing options)
  • Test the ImagePresenter and CloudinaryUrl modules accordingly
Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.