Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@kirillrdy
Copy link

this is similar to @joegsn approach from #150 but also ensures FreeBSD 11 and most importantly OSX are not broken

@kirillrdy
Copy link
Author

hmm, doesn't actually work ... need more testing

@kirillrdy
Copy link
Author

@sparkymat give it a test. Should be all good now

@courtland
Copy link

I'm also interested in this patch or some form of it making its way into the official gem. For now I have accepted this pull request into my own fork. It works for my environment under macOS, FreeBSD-10.1-RELEASE, FreeBSD-11.1-RELEASE, and FreeBSD-12.0-CURRENT.

FreeBSD 12 is indeed not slated to come out until late October / early November 2018, but in my case I have a rails app that must be vetted against FreeBSD-CURRENT in time for its release and bcrypt compilation is one of the road blocks.

It looks like FreeBSD has already adopted some form of this patch in the ports tree.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212304

@kirillrdy
Copy link
Author

I've rebased against latest master and applied patches similar to
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212304

Let me know what you guys think

@tjschuck
Copy link
Collaborator

tjschuck commented Dec 3, 2018

Both of your final changes are in the vendored C implementation that this library uses — please propose them upstream at https://www.openwall.com/crypt/, and then they can be pulled downstream into bcrypt-ruby.

Thanks!

@tjschuck tjschuck closed this Dec 3, 2018
@solardiz
Copy link

Someone posted this PR's URL as a "Quick Comment" at https://www.openwall.com/crypt/ so I just took a look. To me, the weirdest thing is that you're apparently trying to use this wrapper code intended for use inside a libc in a project that isn't a libc. That's why you're running into issues. Perhaps you should be using crypt_blowfish's native interfaces and not the wrappers.

@tymat
Copy link

tymat commented May 1, 2019

This has not been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.