Fix user variables #276
Merged
Fix user variables #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzanj
approved these changes
May 18, 2020
patrick-tolosa
approved these changes
May 18, 2020
| @@ -15,6 +15,10 @@ const isJsonLikeString = function (str: any): boolean { | ||
| return str && typeof str === 'string' && (str.trim().match(/^{[\s\S]*?}$/) !== null); | ||
| }; | ||
|
|
||
| const isArrayLikeString = function (str: any): boolean { |
There was a problem hiding this comment.
Why are we using Any here? I see it in various other places as well,
we really don't know what's coming in?
There was a problem hiding this comment.
Its a string but I wanted to keep the same structure as the other methods. I'll make a separate pr for the rest of the types and verify that its not breaking anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.