Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix user variables #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2020
Merged

Fix user variables #276

merged 1 commit into from
May 19, 2020

Conversation

strausr
Copy link
Contributor

@strausr strausr commented May 17, 2020

No description provided.

@strausr strausr requested review from patrick-tolosa and nitzanj May 17, 2020 10:11
Copy link

@nitzanj nitzanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Not related to this PR - all this boilerplate is for every test??

@@ -15,6 +15,10 @@ const isJsonLikeString = function (str: any): boolean {
return str && typeof str === 'string' && (str.trim().match(/^{[\s\S]*?}$/) !== null);
};

const isArrayLikeString = function (str: any): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using Any here? I see it in various other places as well,
we really don't know what's coming in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a string but I wanted to keep the same structure as the other methods. I'll make a separate pr for the rest of the types and verify that its not breaking anything

@strausr strausr merged commit b7829b4 into master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.