Update readme #154
Merged
Update readme #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strausr
reviewed
Jan 19, 2022
carlevison
reviewed
Jan 19, 2022
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
ghost
suggested changes
Jan 19, 2022
|
@patrick-tolosa - I think you missed some. Probably hidden by GitHub. |
Co-authored-by: Nir Maoz <47939921+maoznir@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
I think I've go them all - please take a look @carlevison |
carlevison
reviewed
Jan 19, 2022
There was a problem hiding this comment.
@patrick-tolosa - one more. Sorry, that was my fault putting the full stop in the wrong place!
jackieros
reviewed
Jan 19, 2022
There was a problem hiding this comment.
@patrick-tolosa
Changed hyphens to colons in Additional Resources section.
Pls update template for future readmes too.
(Sorry about that).
Co-authored-by: carlevison <54800761+carlevison@users.noreply.github.com>
Co-authored-by: Jackie Rosenzveig <jackie@cloudinary.com>
Co-authored-by: Jackie Rosenzveig <jackie@cloudinary.com>
Co-authored-by: Jackie Rosenzveig <jackie@cloudinary.com>
Co-authored-by: Jackie Rosenzveig <jackie@cloudinary.com>
Co-authored-by: Jackie Rosenzveig <jackie@cloudinary.com>
Co-authored-by: Jackie Rosenzveig <jackie@cloudinary.com>
Co-authored-by: Jackie Rosenzveig <jackie@cloudinary.com>
Co-authored-by: Jackie Rosenzveig <jackie@cloudinary.com>
jackieros
reviewed
Jan 19, 2022
asisayag2
reviewed
Jan 19, 2022
| - A `cloudinary.js` file will be added to your src directory, same level with your `main.js` file. Feel free to customize it if you like. And have fun with Cloudinary! 🤟 | ||
| - More information on the plugin, check out [our Vue-CLI plugin for Cloudinary Repo](https://github.com/cloudinary/vue-cli-plugin-cloudinary) | ||
| ## Key Features | ||
| - [Transform](https://cloudinary.com/documentation/vue_video_manipulation#video_transformation_examples) and [optimize](https://cloudinary.com/documentation/vue_image_manipulation#image_optimizations) assets (links to docs). |
There was a problem hiding this comment.
Can we drop the "(link to docs)" at the end?
There was a problem hiding this comment.
We can, but I added it because there are many links in this read me,
I wanted it to be clear that it's an external link and not hijack people away from the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the readme file
Here's a link to the readme assuming this PR would be merged:
https://github.com/cloudinary/cloudinary-vue/blob/feature/improve-readme/README.md#Version-Support