Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Document alternative modes of using the buildpack#96

Closed
cgfrost wants to merge 0 commit intocloudfoundry:mastercloudfoundry/java-buildpack:masterfrom
cgfrost:masterCopy head branch name to clipboard
Closed

Document alternative modes of using the buildpack#96
cgfrost wants to merge 0 commit intocloudfoundry:mastercloudfoundry/java-buildpack:masterfrom
cgfrost:masterCopy head branch name to clipboard

Conversation

@cgfrost
Copy link
Contributor

@cgfrost cgfrost commented Sep 10, 2014

There is no documentation about the different ways that the buildpack can be
used. This commit add documentation about expert mode and offline buildpacks.

[#76619826]

@cfdreddbot
Copy link

Hey cgfrost!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@nebhale
Copy link
Contributor

nebhale commented Sep 15, 2014

@cgfrost You've pushed your master again which means that there's some stuff hanging off the end of the intended commit. Beyond that, some changes that need to be made:

  1. Expert mode does not require a full replica of the online repository. That is the easiest way to create an internal repository, but is not required. The only things that are required are indexes for the components that will be used, pointing to locations that the artifacts can be downloaded from.
  2. Typo in the word "dose't"
  3. You don't have to clone the repository to build a packaged buildpack. There are a number of other options.
  4. Cloning
  5. Tarball (https://github.com/cloudfoundry/java-buildpack/archive/master.tar.gz)
  6. Zip (https://github.com/cloudfoundry/java-buildpack/archive/master.zip)
  7. Release offline package (https://github.com/cloudfoundry/java-buildpack/releases/download/v2.4/java-buildpack-offline-v2.4.zip)
  8. Release tarball (https://github.com/cloudfoundry/java-buildpack/archive/v2.4.tar.gz)
  9. Release zip (https://github.com/cloudfoundry/java-buildpack/archive/v2.4.tar.gz)
  10. Update your version of Bundler (gem update bundler) and rebuild the .iml file. I noticed that you reverted it's listing to an earlier version.

I think the structure should be something like:

  • Buildpack Modes
  • Easy Mode
    • How to clone
    • Where to download releases
    • How to use create-buildpack, update-buildpack
  • Expert Mode
    • Forking/downloading sources
    • Modification to make
    • How to use create-buildpack, update-buildpack
    • Replicating the repository (optional)
  • Offline Mode
    • How to clone
    • Where to download releases
    • How to build offline package
    • How to use create-buildpack, update-buildpack

That's just a rough outline, and my be missing things, but points you in the right direction.

@cgfrost cgfrost closed this Sep 16, 2014
nebhale added a commit that referenced this pull request Sep 17, 2014
These changes bring the submission in line with the suggestions in
issue #96.

[#76619826]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.