[main] Use embedded process instances for "cf apps" summary#3726
Open
jochenehret wants to merge 3 commits intocloudfoundry:maincloudfoundry/cli:mainfrom
sap-contributions:main_apps_cmd_process_instancessap-contributions/cli:main_apps_cmd_process_instancesCopy head branch name to clipboard
Open
[main] Use embedded process instances for "cf apps" summary#3726jochenehret wants to merge 3 commits intocloudfoundry:maincloudfoundry/cli:mainfrom sap-contributions:main_apps_cmd_process_instancessap-contributions/cli:main_apps_cmd_process_instancesCopy head branch name to clipboard
jochenehret wants to merge 3 commits intocloudfoundry:maincloudfoundry/cli:mainfrom
sap-contributions:main_apps_cmd_process_instancessap-contributions/cli:main_apps_cmd_process_instancesCopy head branch name to clipboard
Conversation
* use "/v3/processes?space_guids=:guid&embed=process_instances" to get processes and process instances in one request * see cloudfoundry/cloud_controller_ng#4796
Contributor
Author
Contributor
Author
|
Integration test is still failing. It should succeed once https://github.com/cloudfoundry/capi-release/releases/tag/1.229.0 is used (last run was with 1.228.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Use the new "embedded process instances" cloud controller feature to speed up the
cf appscommand, in particular on spaces with a larger number of apps. Instead of calling the individual/statsendpoint per process, use this request once per space:GET /v3/processes?space_guids=:guid&embed=process_instancesWhy Is This PR Valuable?
Time comparison on a test space with 100 apps and 2 instances each:
Applicable Issues
cloudfoundry/cloud_controller_ng#4796
How Urgent Is The Change?
Not super-urgent.