Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

Talador12
Copy link

  • Add hardTimeoutMs to StartupOptions struct
  • Implement hard timeout RPC call during container.start()
  • Add setHardTimeout @8 method to container.capnp schema
  • Hard timeout is absolute from startup, unlike inactivity timeout

@Talador12 Talador12 requested review from a team as code owners October 10, 2025 19:58
Copy link

github-actions bot commented Oct 10, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Talador12
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 10, 2025
src/workerd/api/container.h Outdated Show resolved Hide resolved
src/workerd/io/container.capnp Outdated Show resolved Hide resolved
@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch 3 times, most recently from 6b2a1f8 to 4ceb2b8 Compare October 10, 2025 20:13
Copy link
Contributor

@gabivlj gabivlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending tests passing

src/workerd/io/container.capnp Outdated Show resolved Hide resolved
src/workerd/api/container.h Show resolved Hide resolved
src/workerd/io/container.capnp Outdated Show resolved Hide resolved
src/workerd/api/container.c++ Outdated Show resolved Hide resolved
src/workerd/api/container.c++ Outdated Show resolved Hide resolved
- Add hardTimeout to StartupOptions (accepts duration string or ms number)
- Only expose hardTimeout field when workerdExperimental flag is enabled
- Add hardTimeoutMs to StartParams in container.capnp schema
- Parse duration strings like '30s', '5m', '2h' with proper validation
- Hard timeout is absolute from startup, unlike inactivity timeout
- Integrated directly into start() call per PR feedback
@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch from 4ceb2b8 to 8ee2eee Compare October 13, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.