-
Notifications
You must be signed in to change notification settings - Fork 457
feat: Add hard timeout support to container startup #5280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Talador12
wants to merge
2
commits into
cloudflare:main
Choose a base branch
from
Talador12:feature/hard-timeout-startup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Talador12
commented
Oct 10, 2025
- Add hardTimeoutMs to StartupOptions struct
- Implement hard timeout RPC call during container.start()
- Add setHardTimeout @8 method to container.capnp schema
- Hard timeout is absolute from startup, unlike inactivity timeout
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
gabivlj
reviewed
Oct 10, 2025
6b2a1f8
to
4ceb2b8
Compare
gabivlj
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending tests passing
justin-mp
reviewed
Oct 13, 2025
justin-mp
reviewed
Oct 13, 2025
justin-mp
reviewed
Oct 13, 2025
justin-mp
reviewed
Oct 13, 2025
justin-mp
reviewed
Oct 13, 2025
- Add hardTimeout to StartupOptions (accepts duration string or ms number) - Only expose hardTimeout field when workerdExperimental flag is enabled - Add hardTimeoutMs to StartParams in container.capnp schema - Parse duration strings like '30s', '5m', '2h' with proper validation - Hard timeout is absolute from startup, unlike inactivity timeout - Integrated directly into start() call per PR feedback
4ceb2b8
to
8ee2eee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.