-
Notifications
You must be signed in to change notification settings - Fork 55
[MIGRATION] Add note about authentication errors and server errors #512
Conversation
MIGRATION.md
Outdated
1. Custom HTTP client configurations in `python-cloudant` are not transferable to `python-java-sdk`. For more information go to the [Configuring the HTTP client section(https://githubcom/IBM/ibm-cloud-sdk-common/#configuring-the-http-client) in the IBM Cloud SDK Common README. | ||
1. Custom HTTP client configurations in `python-cloudant` are not transferable to | ||
`cloudant-python-sdk`. For more information go to the [Configuring the HTTP client section | ||
(https://githubcom/IBM/ibm-cloud-sdk-common/#configuring-the-http-client) in the IBM Cloud SDK Common README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(https://githubcom/IBM/ibm-cloud-sdk-common/#configuring-the-http-client) in the IBM Cloud SDK Common README. | |
(https://github.com/IBM/ibm-cloud-sdk-common/#configuring-the-http-client) in the IBM Cloud SDK Common README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in d8a1756
MIGRATION.md
Outdated
`cloudant-python-sdk`. For more information go to the [Configuring the HTTP client section | ||
(https://github.com/IBM/ibm-cloud-sdk-common/#configuring-the-http-client) in the IBM Cloud | ||
SDK Common README. | ||
1. Authentication errors turn out at the time of instantiation of a client, while errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you plan to update this chapter too, like you did with java and nodejs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I just need to figure out what is the authentication error message first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 15a9b60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for the reviews @emlaver, @vmatyusGitHub! I am merging this! |
Checklist
CHANGES.md
|CHANGELOG.md
) or test/build only changesDescription
There have been some questions regarding migration lately. This PR tries to address them.
Approach
I clarified some of the questionable topics in this change:
I also fixed a typo from python-java-sdk to cloudant-python-sdk
My IDE lately breaks the lines automatically, I have not figured out how I can turn it off yet, but I think this is a great feature, and it helps the reviewers to read the long lines more effectively, so I kept these modifications.
Schema & API Changes
Security and Privacy
Testing
Monitoring and Logging