Support boolean type for key, endkey, and startkey in view requests
#504
Conversation
There was a problem hiding this comment.
There's a couple of invalid tests that should be removed since boolean type is valid. For example: https://github.com/cloudant/python-cloudant/blob/master/tests/unit/param_translation_tests.py#L298
and
https://github.com/cloudant/python-cloudant/blob/master/tests/unit/param_translation_tests.py#L243
We'll also want to modify existing tests to validate boolean types.
CHANGES.md
Outdated
| @@ -5,6 +5,7 @@ | ||
| - [FIXED] Fixed result paging for grouped view queries. | ||
| - [FIXED] Incorrect use of username as account name in `Cloudant.bluemix()`. | ||
| - [IMPROVED] Documented use of None account name and url override for `Cloudant.iam()`. | ||
| - [FIXED] View with a boolean type key. |
There was a problem hiding this comment.
What about:
[FIXED] Support boolean type for key(s) in view requests.
There was a problem hiding this comment.
I used:
[FIXED] Support boolean type for key, endkey, and startkey in view requests.
3988cae to
d395a1a
Compare
I fixed the tests in e876a39 then I realized there is a need for a modification in the code to pass the tests: d89eba6. |
key, endkey, and startkey in view requests
This reverts commit c4b38fb.
49962d1 to
86ffcb7
Compare
Co-authored-by: Rich Ellis <ricellis@users.noreply.github.com>
Checklist
CHANGES.md) or test/build only changesDescription
Fixes #494
Approach
Allow bool type for
endkey,key, andstartkey.Schema & API Changes
Security and Privacy
Testing
Edited the
invalidtests to use{'foo': 'bar'}invalid values instead of booleans, and extended the existing tests to validate boolean types.Monitoring and Logging