Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Update test server config #498

Merged
merged 4 commits into from
May 25, 2021
Merged

Update test server config #498

merged 4 commits into from
May 25, 2021

Conversation

ricellis
Copy link
Member

@ricellis ricellis commented May 19, 2021

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md) or test/build only changes
  • Completed the PR template below:

Description

Change the test server configuration and allow for overriding the token server used by tests.
Fix Cloudant.bluemix() handling of username/account.

1. Steps to reproduce and the simplest code sample possible to demonstrate the issue

Run Jenkins with a custom IAM token server.

2. What you expected to happen

Tests to pass.

3. What actually happened

Test failures.

Approach

  • Add IAM_TOKEN_URL environment variable to IAM test runs
  • Add new env vars and cred IDs to Jenkinsfile - use DB_URL instead of CLOUDANT_ACCOUNT
  • Fix tests to work with above (see "Testing" below)

The Cloudant.bluemix() function was assuming that the username was the account name. This does not work with the new style account credentials where username does not match account name. The URL was already being correctly provided, so just use None as the account name instead.

Schema & API Changes

  • "No change"

Security and Privacy

  • "No change"

Testing

  • Modified existing tests because many made the assumption they would be run with CLOUDANT_ACCOUNT instead of a service URL.

Test run is on the whole pretty stable except:

  1. replication tests which appear to have exposed a regression in Cloudant. I've temporarily disabled checking on replication progress via scheduler docs on this branch to demonstrate that these changes are good pending resolution of that server side problem.
  2. periodically exceeding the rate limit on the account

Monitoring and Logging

  • "No change"

@ricellis ricellis self-assigned this May 20, 2021
@ricellis ricellis added this to the 2.next milestone May 20, 2021
@ricellis ricellis marked this pull request as ready for review May 20, 2021 13:42
@ricellis ricellis merged commit 29a67ee into master May 25, 2021
@ricellis ricellis deleted the new-test-server branch May 25, 2021 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.