This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Update test server config #498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md
) or test/build only changesDescription
Change the test server configuration and allow for overriding the token server used by tests.
Fix
Cloudant.bluemix()
handling of username/account.1. Steps to reproduce and the simplest code sample possible to demonstrate the issue
Run Jenkins with a custom IAM token server.
2. What you expected to happen
Tests to pass.
3. What actually happened
Test failures.
Approach
IAM_TOKEN_URL
environment variable to IAM test runsJenkinsfile
- useDB_URL
instead ofCLOUDANT_ACCOUNT
The
Cloudant.bluemix()
function was assuming that the username was the account name. This does not work with the new style account credentials where username does not match account name. The URL was already being correctly provided, so just useNone
as the account name instead.Schema & API Changes
Security and Privacy
Testing
CLOUDANT_ACCOUNT
instead of a service URL.Test run is on the whole pretty stable except:
Monitoring and Logging