Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add ClojureCLR support #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2022
Merged

Add ClojureCLR support #203

merged 3 commits into from
Jul 23, 2022

Conversation

E-A-Griffin
Copy link
Contributor

Added support for ClojureCLR repl via lein-clr. Updated README to reflect changes.

inf-clojure.el Outdated
@@ -75,6 +75,7 @@
(boot . "boot repl")
(clojure . "clojure")
(cljs . "clojure -m cljs.main -r")
(cljr . "lein clr repl")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to name this lein-cljr in case we decide to add more ways to start a cljr repl down the road.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or lein-clr)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree, especially with the hope that more modern tools for cljr repls become available soon.

@bbatsov
Copy link
Member

bbatsov commented Jul 21, 2022

Please, mention this in the changelog as well.

@bbatsov
Copy link
Member

bbatsov commented Jul 22, 2022

Btw, I've also noticed that lein-clr hasn't been updated in 7 years, but I guess it still gets the job done.

@E-A-Griffin
Copy link
Contributor Author

Btw, I've also noticed that lein-clr hasn't been updated in 7 years, but I guess it still gets the job done.

Yeah I noticed that as well. There's at least one feature I think it should be updated to include (dealing with dependency management for Clojure/ClojureScript/ClojureCLR projects where some dependencies aren't compatible with all three variants of Clojure). I may reach out to the repo owner and see if it would be appropriate to move the repo to something like https://github.com/clj-commons. I'd be willing to try to contribute to its maintenance though I wouldn't want to take on that responsibility solely.

@bbatsov
Copy link
Member

bbatsov commented Jul 22, 2022

Sounds like a good idea to move the project to clj-commons.

@E-A-Griffin
Copy link
Contributor Author

Let me know if these changes address all concerns or if further changes are still needed.

CHANGELOG.md Outdated
@@ -123,3 +123,4 @@
### New Features

* [#22](https://github.com/clojure-emacs/inf-clojure/pull/22): Add ElDoc support.
* [#202](https://github.com/clojure-emacs/inf-clojure/issues/202): Add ClojureCLR support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be under the master section.

@bbatsov
Copy link
Member

bbatsov commented Jul 23, 2022

@E-A-Griffin Just move the changelog entry and we're good to go.

@E-A-Griffin
Copy link
Contributor Author

@E-A-Griffin Just move the changelog entry and we're good to go.

Awesome, should be good now then.

@bbatsov bbatsov merged commit f436760 into clojure-emacs:master Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.