-
-
Notifications
You must be signed in to change notification settings - Fork 44
Add ClojureCLR support #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
inf-clojure.el
Outdated
@@ -75,6 +75,7 @@ | ||
(boot . "boot repl") | ||
(clojure . "clojure") | ||
(cljs . "clojure -m cljs.main -r") | ||
(cljr . "lein clr repl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to name this lein-cljr
in case we decide to add more ways to start a cljr repl down the road.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(or lein-clr
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree, especially with the hope that more modern tools for cljr
repls become available soon.
Please, mention this in the changelog as well. |
Btw, I've also noticed that |
Yeah I noticed that as well. There's at least one feature I think it should be updated to include (dealing with dependency management for Clojure/ClojureScript/ClojureCLR projects where some dependencies aren't compatible with all three variants of Clojure). I may reach out to the repo owner and see if it would be appropriate to move the repo to something like https://github.com/clj-commons. I'd be willing to try to contribute to its maintenance though I wouldn't want to take on that responsibility solely. |
Sounds like a good idea to move the project to |
Let me know if these changes address all concerns or if further changes are still needed. |
CHANGELOG.md
Outdated
@@ -123,3 +123,4 @@ | ||
### New Features | ||
|
||
* [#22](https://github.com/clojure-emacs/inf-clojure/pull/22): Add ElDoc support. | ||
* [#202](https://github.com/clojure-emacs/inf-clojure/issues/202): Add ClojureCLR support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be under the master
section.
@E-A-Griffin Just move the changelog entry and we're good to go. |
Awesome, should be good now then. |
Added support for ClojureCLR repl via
lein-clr
. Updated README to reflect changes.