Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove reader conditional from Clojure repl type arglists default config #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

JasonKDarby
Copy link
Contributor

The existing configuration causes Clojure repls to fail with java.lang.RuntimeException: Conditional read not allowed as soon as arglists are requested.

I ran into this while using an embedded nrepl configured with transport/tty, here's a dummy project you can use to try it out.

It's not clear to me if this is sacrificing functionality that nrepl transport/tty doesn't implement or if it never worked.

Thanks for inf-clojure!


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@JasonKDarby
Copy link
Contributor Author

It looks like this undoes #164, maybe a better fix exists.

@dpsutton
Copy link
Contributor

dpsutton commented May 2, 2022

@JasonKDarby good find. I opened a ticket against nrepl to see if we could get the tty transport to allow for reader conditionals. We'll see if they think that's a good change: nrepl/nrepl#272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.