Function to select repls as the current active connection #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca9301e to
3aad040
Compare
very simple: if in a repl, use that. if not in a repl, display a list of inf-clojure process buffers. If given a prefix, always show a list. Makes running simultaneous repls far easier
3aad040 to
22ffacd
Compare
bbatsov
reviewed
Mar 20, 2021
inf-clojure.el
Outdated
| repls and offer a choice. Recommended to rename buffers as they | ||
| are created with `rename-buffer`." | ||
| (interactive "P") | ||
| (cl-flet ((inf-clojure-repl-p () (and (derived-mode-p 'inf-clojure-mode) |
There was a problem hiding this comment.
I'd suggest having this and a inf-clojure-repls fucntion to be top-level functions. I can imagine they'd be useful in some other situations as well.
|
Nice little change indeed. Might also be a good idea to update the modeline for |
|
Looks like I will have to try inf-clojure again 😃 Good idea here! |
note this changes the `inf-clojure-buffer` to always be a _buffer_ and not the name of a buffer. Seems like renaming can be quite risky since it was just a name of the buffer rather than the buffer.
|
|
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful little function to ease the use case of multiple connections. There's a global connection that all commands use:
inf-clojure-buffer. Changing this allows using different connections. This function just sets that to current buffer if in a repl, shows a list of live process inf-clojure repls if not, and if given a prefix, always shows a list so you can switch even if you're currently in a repl. The repl type is in a defvar-localinf-clojure-repl-typeso that doesn't need to be set or re-inferred.Renaming buffers with projects and repl types makes this quite nice, and the dead simple way it works means that things can be evaluated from any buffer (project irrespective) and no edge cases like last focused buffer or anything like that.