Frankly, I don't understand what exactly is the point of doing this change. You can always override the lein/boot command for a specific project, so if something is lein/boot and you need a different command to be used the option is always there for you. If it's not - you end up using the generic command anyways.

I know very well that trick, using it all the time. However the scenario here is different: in lumo projects you don't need to have a build.boot or a project.clj...except that sometimes you want to resolve maven dependencies, which comes afterwards in most of my projects.

So all of a sudden you introduce the file (say project.clj) and boom, nothing works anymore because now inf-clojure detects and wants you to customize inf-clojure-lein-cmd. Ok I am going to do it. Say some time ago you realize that you want to switch to build.boot, because it is better (it really is faster for maven resolution). Boom again, now you have to customize inf-clojure-boot-cmd.

This back and forth happens in many scenarios (one other weird one is when you generate a project with lein new but you are not actually using lein, it is just for having a ready project.clj).

My rationale on this is that when I am in a lumo project I want to be able to decide what to do independently from the project type.

I think what you really want to do is not to skip project detection but to be able to specify a generic project type via .dir-locals.el. That'd be the Emacs way of doing things.

I am fine with that too, it still involves adding one more line in .dir-locals.el, same as this patch. Probably no difference. Will try that out cause if no patch necessary it its better.

Hello again @bbatsov, I have checked the code but it seems that there is no defcustom for project type.

What would you suggest me to do here? Add one for project type? Then we'd need also a more flexible one for the command..(handle any possible commands for any possible project type?).

Seems like a bigger change.

So to explain the problem better, in my folder I have both project.clj and build.boot and this is my .dir-locals.el with this patch.

((nil . ((eval . (add-hook 'clojure-mode-hook #'inf-clojure-minor-mode))
         (inf-clojure-repl-use-same-window . "different")
         (inf-clojure-skip-project-detection . t)
         (inf-clojure-generic-cmd . ("localhost" . 5044)))))

What would you suggest me to do here? Add one for project type? Then we'd need also a more flexible one for the command..(handle any possible commands for any possible project type?).

This just had to be checked by the inf-clojure-project-type command and take precedence over the existing detection logic. Doesn't seem like a big change to me.

Got it, so you would prefer to create a defcustom containing a custom project type.

What would the project type use as -cmd? I am not that elisp expert, can you create a defvar like inf-clojure-${project-type}-cmd from .dir-locals.el?

At the moment we have three defcustom: inf-clojure-boot-cmd, inf-clojure-lein-cmd and the catch all inf-clojure-generic-cmd.

I see in projectile something like this, which makes total sense, but this changes things a bit:

(projectile-register-project-type 'npm '("package.json")
				  :compile "npm install"
				  :test "npm test"
				  :run "npm start"
				  :test-suffix ".spec")

Maybe our detection can interact with projectile and see if there is a declared project type already and use that command declared in there. Projectile would need to handle the :repl tag though.

Fairly complicated I know, I still like my small hack better.

Got it, so you would prefer to create a defcustom containing a custom project type.

A defvar actually. It shouldn't be a custom project type. Just something that overrides the regular detection, that in your case you'd set to generic and also override the generic cmd.

Seems to me that this solves your problem completely.

Maybe our detection can interact with projectile and see if there is a declared project type already and use that command declared in there. Projectile would need to handle the :repl tag though.

We can always add some integration with projectile as well - that'd be pretty simple. But this should be something optional, as we don't want to force Projectile on everyone.

Isn't a defvar that overrides the logic exactly what I am doing? Maybe I don't understand your solution here.

The inf-clojure-skip-project-detection overrides code detection so that we always take the generic command.

Yeah, but you're making something very specific (you can just make something generic) and it should be able to force whatever project type you want to. That's what started all of my comments. I don't like very specific options, normally I'd make something as generic as possible.

I've explained in the code exactly what I mean. Hopefully now you understand me.

Thanks should be clear now, will change this patch.

@bbatsov done, can you review please. I want to be sure I got it right.