Dynamically upgrade nrepl connection #3044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
9fbf04f to
f21e727
Compare
|
Apparently |
f21e727 to
7aa3e03
Compare
|
And it seems relying on internals of |
7aa3e03 to
8670fc1
Compare
|
Good thing we test on Emacs 25/26/27, and I use 28. Seems in 28 the implementation of arc-mode was changed to use structs instead of vectors. Will look into the remaining failures tomorrow. |
2c06783 to
ab89ac5
Compare
Piece together the final pieces to make dynamic loading + sideloading of middleware work. - Add cider-jar mini-library : download jars, list their contents and extract files - Install unzip on CI, needed by arc-mode which we use for the jars
ab89ac5 to
7456966
Compare
06ee79f to
bdb4bc0
Compare
|
That... actually worked :D CI is looking ok now, apart from the invisible windows builds. Could potentially use an extra one or two tests for the stuff in cider-eval. I'll do docs in a separate PR. |
|
Great work! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piece together the final pieces to make dynamic loading + sideloading of
middleware work.
This introduces
M-x cider-upgrade-nrepl-connection, which combines the different steps neededThis introduces a cider-jar mini library for looking up jars and files in jars fairly efficiently and in a cross-platform manner.
Part of #3037
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)eldev lint) which is based onelisp-lintand includescheckdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.Thanks!
If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.