Migrate PR triage workflows to shared workflows#12707
Merged
Migrate PR triage workflows to shared workflows#12707
Conversation
Replace prauto.yml and pr-help-wanted.yml with a single triage-pull-requests.yml that calls shared reusable workflows from desktop/gh-cli-and-desktop-shared-workflows: - triage-label-external-pr: labels external PRs with external,needs-triage - triage-close-from-default-branch: closes PRs opened from trunk - triage-pr-requirements: enforces body length + help-wanted issue linkage - triage-close-no-help-wanted: closes PRs labeled no-help-wanted-issue - triage-ready-for-review: removes needs-triage on ready-for-review label Also adds a daily schedule to auto-close PRs with unmet requirements after 7 days. Deletes: - prauto.yml - pr-help-wanted.yml - scripts/check-help-wanted.sh Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates pull request triage automation from repo-local workflows/scripts to reusable workflows in desktop/gh-cli-and-desktop-shared-workflows, consolidating PR triage behaviors into a single workflow.
Changes:
- Add a new consolidated PR triage workflow (
triage-pull-requests.yml) that calls shared reusable workflows for labeling/closing/checking PRs and a daily scheduled task. - Remove legacy PR automation workflows (
prauto.yml,pr-help-wanted.yml) and the now-unused helper script (check-help-wanted.sh).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/triage-pull-requests.yml |
New consolidated workflow wiring PR triage events + schedule to shared reusable workflows. |
.github/workflows/scripts/check-help-wanted.sh |
Removed obsolete script (help-wanted linkage checks) now handled via shared workflow. |
.github/workflows/prauto.yml |
Deleted legacy PR automation workflow replaced by shared workflows. |
.github/workflows/pr-help-wanted.yml |
Deleted legacy workflow replaced by shared PR requirements workflow. |
Comments suppressed due to low confidence (1)
.github/workflows/triage-pull-requests.yml:37
triage-pr-requirementsis described as applying anunmet-requirementslabel and possibly commenting/closing PRs. Those actions typically requireissues: writeon the caller workflow token; withissues: readhere the reusable workflow may fail to apply labels/comments. Consider changing this job's permissions toissues: write(write includes read).
permissions:
issues: read
pull-requests: write
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+42
| issues: read | ||
| pull-requests: write | ||
|
|
||
| close-unmet-requirements: | ||
| if: github.event_name == 'schedule' | ||
| uses: desktop/gh-cli-and-desktop-shared-workflows/.github/workflows/triage-pr-requirements.yml@main | ||
| permissions: | ||
| issues: read |
There was a problem hiding this comment.
Same as above for the scheduled run: if triage-pr-requirements needs to add/remove labels or leave comments when closing PRs, issues: read may be insufficient. Consider granting issues: write for this job too.
This issue also appears on line 34 of the same file.
Suggested change
| issues: read | |
| pull-requests: write | |
| close-unmet-requirements: | |
| if: github.event_name == 'schedule' | |
| uses: desktop/gh-cli-and-desktop-shared-workflows/.github/workflows/triage-pr-requirements.yml@main | |
| permissions: | |
| issues: read | |
| issues: write | |
| pull-requests: write | |
| close-unmet-requirements: | |
| if: github.event_name == 'schedule' | |
| uses: desktop/gh-cli-and-desktop-shared-workflows/.github/workflows/triage-pr-requirements.yml@main | |
| permissions: | |
| issues: write |
Comment on lines
+29
to
+33
| check-requirements: | ||
| if: >- | ||
| github.event_name == 'pull_request_target' && | ||
| (github.event.action == 'opened' || github.event.action == 'reopened' || github.event.action == 'edited') | ||
| uses: desktop/gh-cli-and-desktop-shared-workflows/.github/workflows/triage-pr-requirements.yml@main |
There was a problem hiding this comment.
pull_request_target includes ready_for_review, but none of the jobs run when github.event.action == 'ready_for_review'. This means draft PRs that become ready may never get external labeling / default-branch closing / requirement checks. Consider including ready_for_review in the relevant job if: conditions (or adding a dedicated job for that action).
williammartin
approved these changes
Feb 17, 2026
tidy-dev
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #12677 by migrating the PR triage workflows (
prauto.yml,pr-help-wanted.yml) to shared reusable workflows.Changes
New
triage-pull-requests.yml— single workflow calling shared workflows for:external,needs-triage)trunkno-help-wanted-issueDeleted
prauto.yml— replaced by shared workflowspr-help-wanted.yml— replaced bytriage-pr-requirements.ymlscripts/check-help-wanted.sh— no longer neededBehavioral changes
needs-triage(previously onlyexternal)unmet-requirementslabel and 7-day grace period instead of immediate close