Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to update the Go version from 1.25.5 to 1.25.6 in the project's go.mod file. However, the update doesn't follow the project's established conventions for Go version updates as defined in the bump-go.sh automation script.
Changes:
- Updated the
godirective in go.mod from 1.25.5 to 1.25.6
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| module github.com/cli/cli/v2 | ||
|
|
||
| go 1.25.5 | ||
| go 1.25.6 |
There was a problem hiding this comment.
The go directive should use the major.minor.0 format (e.g., go 1.25.0), not the major.minor.patch format. According to the bump-go.sh script at line 45, the go directive version should be derived as $(cut -d. -f1-2 <<< "$TOOLCHAIN_VERSION").0, which means only major.minor followed by .0. The patch version (1.25.6) should be used in the toolchain directive instead.
| go 1.25.6 | |
| go 1.25.0 | |
| toolchain go1.25.6 |
| module github.com/cli/cli/v2 | ||
|
|
||
| go 1.25.5 | ||
| go 1.25.6 |
There was a problem hiding this comment.
Missing the toolchain directive. Based on the bump-go.sh script (lines 76-78), when updating Go, both the go directive and a toolchain directive should be present. The toolchain directive should be added as toolchain go1.25.6 on line 4 (after the go directive and before the blank line).
| go 1.25.6 | |
| go 1.25.6 | |
| toolchain go1.25.6 |
No description provided.