Fix fmt.Errorf format argument in ParseFullReference#12516
Merged
babakks merged 2 commits intocli:trunkcli/cli:trunkfrom Jan 21, 2026
mikelolasagasti:pr-shared-error-atoimikelolasagasti/cli:pr-shared-error-atoiCopy head branch name to clipboard
Merged
Fix fmt.Errorf format argument in ParseFullReference#12516babakks merged 2 commits intocli:trunkcli/cli:trunkfrom mikelolasagasti:pr-shared-error-atoimikelolasagasti/cli:pr-shared-error-atoiCopy head branch name to clipboard
babakks merged 2 commits intocli:trunkcli/cli:trunkfrom
mikelolasagasti:pr-shared-error-atoimikelolasagasti/cli:pr-shared-error-atoiCopy head branch name to clipboard
Conversation
The error path passed an int to fmt.Errorf with %q, which expects a string. Use the original reference string to avoid a format mismatch. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
Collaborator
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
babakks
approved these changes
Jan 21, 2026
Member
babakks
left a comment
There was a problem hiding this comment.
Good catch, @mikelolasagasti! 🙏
LGTM! Thanks for the fix. 🍻
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Member
|
I just added the underlying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error path passed an int to
fmt.Errorfwith%q, which expects a string. Use the original reference string to avoid a format mismatch.Found testing package in Fedora: