Enhance v2 project handling around nulls by andyfeller · Pull Request #12356 · cli/cli

andyfeller · Dec 22, 2025

This commit applies familiar conditional protections around v2 project items to avoid panics including:

Lines 473 to 492 in baf6299

    
           for _, node := range resp.Assignments.Nodes { 
        
           	if node == nil { 
        
           		continue // likely due to FORBIDDEN results 
        
           	} 
        
           	switch node.Type { 
        
           	case "Issue": 
        
           		issues = append(issues, *node) 
        
           	case "PullRequest": 
        
           		prs = append(prs, *node) 
        
           	default: 
        
           		return fmt.Errorf("unknown Assignments type: %q", node.Type) 
        
           	} 
        
           } 
        
           for _, node := range resp.ReviewRequested.Nodes { 
        
           	if node == nil { 
        
           		continue // likely due to FORBIDDEN results 
        
           	} 
        
           	reviewRequested = append(reviewRequested, *node) 
        
           }

cli/pkg/cmd/pr/view/view.go

Lines 459 to 468 in baf6299

    
           for _, project := range pr.ProjectCards.Nodes { 
        
           	if project == nil { 
        
           		continue 
        
           	} 
        
           	colName := project.Column.Name 
        
           	if colName == "" { 
        
           		colName = "Awaiting triage" 
        
           	} 
        
           	projectNames = append(projectNames, fmt.Sprintf("%s (%s)", project.Project.Name, colName)) 
        
           }

This commit applies familiar conditional protections around v2 project items to avoid panics as mentioned in #12325.

andyfeller · Dec 22, 2025

Sorry, I didn't see #12324

Copilot

Pull request overview

This PR adds null safety guards to prevent panics when processing v2 project items that may contain null entries in their nodes array. This addresses issue #12325 where null project items from the GraphQL API could cause runtime panics.

Key changes:

Added null checks in ProjectsV2ItemsForIssue and ProjectsV2ItemsForPullRequest functions to skip null nodes
Added comprehensive test cases for both issue and pull request scenarios with null project items

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
api/queries_projects_v2.go	Added nil checks before processing project item nodes in both issue and pull request fetching functions
api/queries_projects_v2_test.go	Added test cases to verify null project items are gracefully skipped without errors

The changes are well-implemented and consistent with existing patterns in the codebase (e.g., similar null handling in pkg/cmd/status/status.go lines 473-492 and pkg/cmd/pr/view/view.go lines 459-468). The tests appropriately verify the new behavior, and the fix is applied at the correct layer (API) to protect all downstream consumers from null pointer panics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Enhance v2 project handling around nulls

bad622e

This commit applies familiar conditional protections around v2 project items to avoid panics as mentioned in #12325.

andyfeller requested a review from a team as a code owner December 22, 2025 15:07

andyfeller requested review from babakks and Copilot December 22, 2025 15:07

andyfeller temporarily deployed to cli-automation December 22, 2025 15:07 — with GitHub Actions Inactive

cliAutomation assigned andyfeller Dec 22, 2025

Copilot started reviewing on behalf of andyfeller December 22, 2025 15:07 View session

andyfeller mentioned this pull request Dec 22, 2025

Panic in gh pr view --comments due to nil pointer dereference in project items #12325

Closed

andyfeller closed this Dec 22, 2025

Copilot AI reviewed Dec 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Enhance v2 project handling around nulls#12356

Enhance v2 project handling around nulls#12356
andyfeller wants to merge 1 commit intotrunkcli/cli:trunkfrom
af/12325-pr-view-project-nullcli/cli:af/12325-pr-view-project-nullCopy head branch name to clipboard

andyfeller commented Dec 22, 2025 •

edited

Loading

Uh oh!

andyfeller commented Dec 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	for _, node := range resp.Assignments.Nodes {
	if node == nil {
	continue // likely due to FORBIDDEN results
	}
	switch node.Type {
	case "Issue":
	issues = append(issues, *node)
	case "PullRequest":
	prs = append(prs, *node)
	default:
	return fmt.Errorf("unknown Assignments type: %q", node.Type)
	}
	}

	for _, node := range resp.ReviewRequested.Nodes {
	if node == nil {
	continue // likely due to FORBIDDEN results
	}
	reviewRequested = append(reviewRequested, *node)
	}

	for _, project := range pr.ProjectCards.Nodes {
	if project == nil {
	continue
	}
	colName := project.Column.Name
	if colName == "" {
	colName = "Awaiting triage"
	}
	projectNames = append(projectNames, fmt.Sprintf("%s (%s)", project.Project.Name, colName))
	}

Search code, repositories, users, issues, pull requests...

Comments

Conversation

andyfeller commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andyfeller commented Dec 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

andyfeller commented Dec 22, 2025 •

edited

Loading