Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Discussion options

What's Changed

New Contributors

Full Changelog: v2.55.0...v2.56.0


This discussion was created from the release GitHub CLI 2.56.0.
You must be logged in to vote

Replies: 5 comments · 4 replies

This comment was marked as spam.

This comment was marked as spam.

Comment options

@andyfeller can/should release discussion posts be locked, or is the idea to have people file legit "issues"? Seems a number of spam comments are posted every single time (which I noticed when I'm mentioned). I don't recall seeing a legit comment, and shouldn't those be opened as issues instead?

I appreciate that even then spam is possible, but it shuts down one obvious abuse of bots echo'ing a release note...which I don't understand how that's a thing? It's not even "spam" advertising something. 🤷‍♂️

You must be logged in to vote
4 replies
@BagToad
Comment options

@heaths thanks for mentioning this. I brought it up with the core CLI team to see if there is some context here that would warrant keeping this around.

🗒️ Seems this happens automatically because we use --discussion-category in deployment.yml

@BagToad
Comment options

I created a poll about this.

@heaths
Comment options

2 such spam comments on the latest release. 21% of all releases since you started creating discussions from release activity have had "What's Changed" posts, while 16% of all comments are such posts. Looking at a sampling of comments, seems most are spam (version numbers, off-topic comments, ads) but at least they aren't notifying people @mention'd in the body.

RELEASES=$(gh api graphql --paginate --slurp -f owner=cli -f repo=cli -f query='
query ($owner: String!, $repo: String!, $endCursor: String) {
  repository(owner: $owner, name: $repo) {
    discussions(
      first: 30
      after: $endCursor
      # "General" category
      categoryId: "MDE4OkRpc2N1c3Npb25DYXRlZ29yeTMyMTUzMjA2"
    ) {
      nodes {
        author {
          login
        }
        title
        bodyText
        comments(first: 30) {
          nodes {
            author {
              login
            }
            bodyText
          }
        }
      }
      pageInfo {
        hasNextPage
        endCursor
      }
    }
  }
}' | jq '[.[].data.repository.discussions.nodes[] | select(.author.login == "github-actions")]')

# Rough estimate of spamming duplication comments to total releases:
echo $RELEASES | jq --arg prefix "What's Changed" '. as $nodes | [$nodes[].comments.nodes[] | select(.bodyText | startswith($prefix))] as $spam | ($spam | length) / ($nodes | length)'

# Rough estimate of spamming duplication comments to all comments:
echo $RELEASES | jq --arg prefix "What's Changed" '. as $nodes | [$nodes[].comments.nodes[] | select(.bodyText | startswith($prefix))] as $spam | ($spam | length) / ([$nodes[].comments.nodes[]] | length)'
@williammartin
Comment options

I created #10132 (comment), we'll talk about prioritising it right after Christmas.

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.