Improve consistency of formatting #545
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like no spaces inside soft braces (seemed the initial/base/majority), except in doc, where the reverse was the majority. Fixing indentation (very long lists less indented for saving space). Uniformize error messages. Spaces around operators. Else on previous closing soft brace. Etc. Didn't try to uniformize quotes, though. Manual fixes, some stuff might have been missed.
|
I wanted a sane base to add improvements, like fixing and adding French lists, adding some functions, adding missing docs, etc. |
|
I am so sorry this has sat here so long without a review! I love it, just haven't had time to review it due to the breadth of the changes but they are all really great, love consistency! Many of the items we should add as rules to the linter so they are strongly enforced moving forward. Anyway, will review as soon as I am able, apologies again for letting this sit for so long, this is amazing ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like no spaces inside soft braces (seemed the initial/base/majority),
except in doc, where the reverse was the majority.
Fixing indentation (very long lists less indented for saving space).
Uniformize error messages.
Spaces around operators.
Else on previous closing soft brace.
Etc.
Didn't try to uniformize quotes, though.
Manual fixes, some stuff might have been missed.