[GSOC Taks 2] ceph-devstack Cli logs feature : To Display Teuthology Logs #18
[GSOC Taks 2] ceph-devstack Cli logs feature : To Display Teuthology Logs #18
Conversation
|
Hello @amathuria @VallariAg @zmc here is my gsoc task 2 logs command implementation on ceph-devstack. Looking forward to your feedback. |
|
Disclosure: Github Copilot was used to add doc-strings (like args of function docs/comments) and few one liner python exceptions. Please let me know if this is acceptable or needs to be changed accordingly? |
kamoltat
left a comment
There was a problem hiding this comment.
First round comments for GSOC evaluation, good job! Will not approve the PR since it is just evaluation task.
|
@abhi4578 also can you please rebase your PR against the main branch thank you |
- ``ceph-devstack logs `` displays latest run teuthology logs of given job - ``ceph-devstack logs --log-file `` displace file location of latest run teuthology log of given job
Signed-off-by: Abhi <29863835+abhi4578@users.noreply.github.com>
Co-authored-by: Kamoltat (Junior) Sirivadhna <ksirivad@gmail.com> Signed-off-by: Abhi <29863835+abhi4578@users.noreply.github.com>
- Add appropriate comments for better understanding - Add try, except block while parsing latest job directory paths to catch ValueError - Make flag_set to boolean from str for simplicity in test_logs.py - Added chec condition if teuthology.log file exists before reading to prevent exceptions
- Also replace return statements with exit statements in test_logs.py file because pytest warnings
94f2a8f to
fe0f8b8
Compare
|
@kamoltat I have added commits resolving the above issues and rebased it against main branch. Please review. Find the screenshots of
|
Thank you! |
Adds implementation of logs and --logs-file option
ceph-devstack logsdisplays latest runteuthology logs of given job
ceph-devstack logs --log-filedisplaysfile location of latest run teuthology log of
given job
Adds pytest unit tests to test 'logs' command
test cases using parametrized tests and fixtures