fixing that beat_dburi should be masked like we are doing for backend #9645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9645 +/- ##
=======================================
Coverage 78.30% 78.31%
=======================================
Files 153 153
Lines 19116 19116
Branches 2531 2531
=======================================
+ Hits 14969 14970 +1
Misses 3859 3859
+ Partials 288 287 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auvipy
requested changes
Apr 3, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request extends URL masking to include beat_dburi values, ensuring that sensitive information is consistently protected alongside backend URLs.
- Added a condition to check for 'beat_dburi' in keys.
- Reused the existing maybe_sanitize_url function for masking.
auvipy
reviewed
Apr 3, 2025
There was a problem hiding this comment.
you should also put the change of #9646 (review) in this PR too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description