This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Refactored AppRunner and Console Main to use smaller methods. #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConsoleMain.cs -- Took logic out of this class and moved it to MainRunner.cs AppRunner.cs, MainRunner.cs -- extracted functionality of longer methods into smaller methods
Contributor
savornicesei
left a comment
There was a problem hiding this comment.
Just my thoughts on this PR...
| private void DisplayHelp(OptionSet opts) | ||
| { | ||
| Assembly thisApp = Assembly.GetExecutingAssembly(); | ||
| Stream helpStream = thisApp.GetManifestResourceStream("ThoughtWorks.CruiseControl.Console.Help.txt"); |
Contributor
There was a problem hiding this comment.
Some using(Stream sr = ...) would ensure the streams are properly handled in case of an error.
I also see no need for the WriteHelpToConsole method since it's used only here.
| useShadowCopying); | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Personally I prefer public methods to appear first in a class and then the protected/private ones.
| } | ||
| catch (RemotingException) | ||
| { | ||
| // Sometimes this exception gets thrown and not sure why. |
Contributor
There was a problem hiding this comment.
It would be nice to log the RemotingException errors at debug level.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsoleMain.cs -- Took logic out of this class and moved it to MainRunner.cs
AppRunner.cs, MainRunner.cs -- extracted functionality of longer methods into smaller methods