Improve usefulness of error logging#8
Merged
tkadlec merged 5 commits intocatchpoint:maincatchpoint/WebPageTest.github-action:mainfrom Feb 7, 2022
Merged
Improve usefulness of error logging#8tkadlec merged 5 commits intocatchpoint:maincatchpoint/WebPageTest.github-action:mainfrom
tkadlec merged 5 commits intocatchpoint:maincatchpoint/WebPageTest.github-action:mainfrom
Conversation
Contributor
Author
|
Hi @tkadlec, There is one point that I need clarification on, does the property Thanks |
nucliweb
approved these changes
Jan 24, 2022
Contributor
|
This is looking great so far @dovidgef!
In theory, yes. Might be good to add a quick check here, just to be extra resilient. |
Contributor
Author
|
@tkadlec I added a fallback to |
Contributor
Author
|
@tkadlec anything else needed to get this merged? Thanks |
Contributor
|
Appreciate your patience on this @dovidgef! Looks great...merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using this Action many times we received generic errors like:
This PR logs the actual error message from the Error object allowing users to see more helpful error messages.
The error messages now look like: