Adjusting API request to POST if too much data#180
Merged
claud-io merged 13 commits intocatchpoint:mastercatchpoint/WebPageTest.api-nodejs:masterfrom Dec 2, 2024
max-ostapenko:gentle-mitemax-ostapenko/WebPageTest.api-nodejs:gentle-miteCopy head branch name to clipboard
Merged
Adjusting API request to POST if too much data#180claud-io merged 13 commits intocatchpoint:mastercatchpoint/WebPageTest.api-nodejs:masterfrom max-ostapenko:gentle-mitemax-ostapenko/WebPageTest.api-nodejs:gentle-miteCopy head branch name to clipboard
claud-io merged 13 commits intocatchpoint:mastercatchpoint/WebPageTest.api-nodejs:masterfrom
max-ostapenko:gentle-mitemax-ostapenko/WebPageTest.api-nodejs:gentle-miteCopy head branch name to clipboard
Conversation
…Test Post request support for run test
Contributor
|
Please revert code formatting before submitting the PR |
b55f6b7 to
b28c65b
Compare
Contributor
Author
|
@lbartoli79 please check now |
lbartoli79
reviewed
Nov 3, 2023
max-ostapenko
commented
Nov 3, 2023
lbartoli79
approved these changes
Nov 14, 2023
claud-io
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #177
I'm checking the length of data, and based on the threshold of 6Kb switching the method to POST. (you could adjust it according to server configuration).
Added a test checking that all the parameters are passed in POST request instead of query.